Addressing Issue 32229 - cleaning up IAM_PATTERN properly #32243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Community NoteVoting for Prioritization
For Submitters
|
github-actions
bot
added
service/servicecatalog
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome @mc-etcher 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
justinretzolk
added
bug
github-actions
bot
added
the
sweeper
mc-etcher
changed the title
github-actions
bot
added
the
documentation
|
This fixes an ongoing problem for me and would be amazing if its merged in. |
… ID Create/Parse function names.
% make testacc TESTARGS='-run=TestAccServiceCatalogPrincipalPortfolioAssociation_' PKG=servicecatalog ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/servicecatalog/... -v -count 1 -parallel 2 -run=TestAccServiceCatalogPrincipalPortfolioAssociation_ -timeout 180m === RUN TestAccServiceCatalogPrincipalPortfolioAssociation_basic === PAUSE TestAccServiceCatalogPrincipalPortfolioAssociation_basic === RUN TestAccServiceCatalogPrincipalPortfolioAssociation_iam_pattern === PAUSE TestAccServiceCatalogPrincipalPortfolioAssociation_iam_pattern === RUN TestAccServiceCatalogPrincipalPortfolioAssociation_disappears === PAUSE TestAccServiceCatalogPrincipalPortfolioAssociation_disappears === CONT TestAccServiceCatalogPrincipalPortfolioAssociation_basic === CONT TestAccServiceCatalogPrincipalPortfolioAssociation_disappears --- PASS: TestAccServiceCatalogPrincipalPortfolioAssociation_disappears (33.48s) === CONT TestAccServiceCatalogPrincipalPortfolioAssociation_iam_pattern --- PASS: TestAccServiceCatalogPrincipalPortfolioAssociation_basic (36.61s) --- PASS: TestAccServiceCatalogPrincipalPortfolioAssociation_iam_pattern (25.17s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/servicecatalog 63.818s
% make testacc TESTARGS='-run=TestAccServiceCatalogPrincipalPortfolioAssociation_migrateV0' PKG=servicecatalog ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/servicecatalog/... -v -count 1 -parallel 2 -run=TestAccServiceCatalogPrincipalPortfolioAssociation_migrateV0 -timeout 180m === RUN TestAccServiceCatalogPrincipalPortfolioAssociation_migrateV0 === PAUSE TestAccServiceCatalogPrincipalPortfolioAssociation_migrateV0 === CONT TestAccServiceCatalogPrincipalPortfolioAssociation_migrateV0 --- PASS: TestAccServiceCatalogPrincipalPortfolioAssociation_migrateV0 (113.69s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/servicecatalog 118.950s
ewbankkit
approved these changes
Sep 6, 2023
There was a problem hiding this comment.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccServiceCatalogPrincipalPortfolioAssociation_' PKG=servicecatalog ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/servicecatalog/... -v -count 1 -parallel 2 -run=TestAccServiceCatalogPrincipalPortfolioAssociation_ -timeout 180m
=== RUN TestAccServiceCatalogPrincipalPortfolioAssociation_basic
=== PAUSE TestAccServiceCatalogPrincipalPortfolioAssociation_basic
=== RUN TestAccServiceCatalogPrincipalPortfolioAssociation_iam_pattern
=== PAUSE TestAccServiceCatalogPrincipalPortfolioAssociation_iam_pattern
=== RUN TestAccServiceCatalogPrincipalPortfolioAssociation_disappears
=== PAUSE TestAccServiceCatalogPrincipalPortfolioAssociation_disappears
=== RUN TestAccServiceCatalogPrincipalPortfolioAssociation_migrateV0
=== PAUSE TestAccServiceCatalogPrincipalPortfolioAssociation_migrateV0
=== CONT TestAccServiceCatalogPrincipalPortfolioAssociation_basic
=== CONT TestAccServiceCatalogPrincipalPortfolioAssociation_disappears
--- PASS: TestAccServiceCatalogPrincipalPortfolioAssociation_disappears (33.61s)
=== CONT TestAccServiceCatalogPrincipalPortfolioAssociation_iam_pattern
--- PASS: TestAccServiceCatalogPrincipalPortfolioAssociation_basic (37.13s)
=== CONT TestAccServiceCatalogPrincipalPortfolioAssociation_migrateV0
--- PASS: TestAccServiceCatalogPrincipalPortfolioAssociation_iam_pattern (28.01s)
--- PASS: TestAccServiceCatalogPrincipalPortfolioAssociation_migrateV0 (117.86s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/servicecatalog 160.253s
|
@mc-etcher Thanks for the contribution 🎉 👏. |
|
This functionality has been released in v5.16.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses issue 32229
Relations
Closes #32229
Closes #33038
References
Output from Acceptance Testing